Now cregex "appears" to be included (for backward compatibility) #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iximiel
force-pushed
the
fix2.10/phantomcregex
branch
from
d72d0ed to
06c2cbd
Compare
|
I rebased on the current v2.10 because #1166 is now merged, so the tests should pass I also added a test to check the "phantom" cregex with a comment that explain why it is there (and ran astyle because I forgot that...) |
|
I am merging it and then we can reduce the numerical precision of that single failing test |
I do no think there is a need to do that: the CI looks like is passing with no problems(apart the usual mac one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
rt-coverage-antibetarmsd fails due to what is being solved here #1166
As what's told in #1175 I'm pushing a couple of commit that should solve the backward compatibility with "absence" of
cregex.In the first two I declare that cregex is there in config.txt (
plumed config has cregex) and inPLMD::config::hasCregex()Target release
I would like my code to appear in release v2.10
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests